search

gnebbia / kb

A minimalist command line knowledge base manager
GNU General Public License v3.0
3.17k stars 104 forks source link

Create Aliases on Windows #60

Closed UweZiegenhagen closed 4 years ago

UweZiegenhagen commented 4 years ago

What does this implement/fix? Explain your changes.

Added comments on how to add aliases in Windows

Does this close any currently open issues?

no

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ or https://bpaste.net and insert the link here.)

no

Any other comments?

nice tool, great work

Where has this been tested?

Operating System: Windows 10 PRO

Platform: ...

Target Platform: ...

alshapton commented 4 years ago

@UweZiegenhagen This is a great bit of work for those in the Windows community. I think that it may be better to have the aliases for various flavours of *nix / MacOS / Windows etc in a folder where people can take the one they want and add it to their profile/startup script etc. The aliases listed in the README now and yours could form the basis of that - with corresponding instructions in the README pointing people to those files. Thoughts ?

UweZiegenhagen commented 4 years ago

Good idea. However I only started using kb so I'm a newbie. My proposal is to leave it in README.MD for the moment. I see if I can invest some time to move it into another document in the next days.

alshapton commented 4 years ago

That's OK, Uwe - thank you for your contribution and welcome to the world of kb !!!

On Sat, Oct 17, 2020 at 3:07 PM Uwe Ziegenhagen notifications@github.com wrote:

Good idea. However I only started using kb so I'm a newbie. My proposal is to leave it in README.MD for the moment. I see if I can invest some time to move it into another document in the next days.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gnebbia/kb/pull/60#issuecomment-711001318, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCMMEBMWMGKMTM2Z7QWC63SLGQIJANCNFSM4SULYDCA .

alshapton commented 4 years ago

@UweZiegenhagen Do you want this PR to be accepted now, or will you work on putting it in a couple of files over the next days, and then we'll accept the PR (or we can do it now)

UweZiegenhagen commented 4 years ago

@alshapton Please accept now, I'll be pretty busy the next days.

gnebbia commented 4 years ago

Ok, sorry for the delay in merging this, anyway I added additional documentation to allow user to perform all the steps by command line. Let me know what do you think. I detailed the insertion of the aliases both for cmd.exe and powershell and I also added how to set the EDITOR variable with both shells.