gneiru / kd

Ad-free Kdrama streaming app. Built with Nextjs, Drizzle ORM, NeonDB and shadcn-UI
https://kd.rohi.dev
MIT License
103 stars 17 forks source link

Add to watchlist not showing #134

Open skgupta507 opened 2 months ago

skgupta507 commented 2 months ago

hey @gneiru the add to watchlist button is not showing on my deployment can u help me with this error pls. i have attached screenshot of it.

image

gneiru commented 2 months ago

Oh, it seems you have to change the email address here. Afterwards insert the series you want in db via button

https://github.com/gneiru/kd/blob/8182f0b01108ea78af30d1afab89939a8f601a11/src/app/(pages)/drama/%5Bslug%5D/page.tsx#L198

skgupta507 commented 2 months ago

Oh, it seems you have to change the email address here. Afterwards insert the series you want in db via button

https://github.com/gneiru/kd/blob/8182f0b01108ea78af30d1afab89939a8f601a11/src/app/(pages)/drama/%5Bslug%5D/page.tsx#L198

Hi so if i change the email it will work for me. but i have a doubt .......... if i use my mail id instead of urs it will work for me. but what about other users using my deployment. will it work for them also.

gneiru commented 2 months ago

It is supposed to be accessible only by the admin. But if you want all users, you can remove that line of code

skgupta507 commented 2 months ago

It is supposed to be accessible only by the admin. But if you want all users, you can remove that line of code

what i meant was is it not possible for the users to add the series to thier watchlist instead of the admin creating the database n then allowing the users to add thier own. cant it be added directly. like it will be lot of work to add every available series to the database right.

gneiru commented 2 months ago

Currently, they cannot add series in their watchlist that are not inserted in database.

Why?

Once the user add something in watchlist, the app will not know the image and title because it only saves its slug (identifier)

Why not insert the image and title upon adding watchlist?

I have thoughts about this before, but since we are also upserting drama series in the database, imo it is better to just query the watchlist and join related series connected thru the slug.

Since the button is not only for inserting drama data, it also updates the data (if already inserted) when there are changes in the series details e.g title, image, number of episodes

Advantages of doing this will match the drama details in home page even after the user added the series in their watchlist.

gneiru commented 2 months ago

And yes this watchlist thing needs improvement, let me know what you think.

skgupta507 commented 2 months ago

And yes this watchlist thing needs improvement, let me know what you think.

do u use Discord or have a Discord server where we can share our suggestions n all that. or other socials we can connect with