search

gnembon / carpet-autoCraftingTable

autoCraftingTable extension for carpet-mod
GNU Lesser General Public License v3.0
80 stars 27 forks source link

Easy dupe with crafting table in unloaded chunk #18

Closed NikitaCartes closed 3 years ago

NikitaCartes commented 3 years ago

Reproduction steps: 1) Place items in crafting table 2) Get into minecart and start leaving 3) Open crafting table while you'rу close to it (First screenshot) 4) Drive long distance (~500 blocks on server with view-distance=16) and pick up items from crafting table (Second screenshot) 5) Go back to crafting table and find two copies of the items: in inventory and crafting table (Third screenshot)

image image image

evermoreobsolete commented 3 years ago

This is a wider issue as the crafting table screen should close when a player goes out of range of the table. I've submitted a patch that should reintroduce the range check and in turn should mean this dupe is impossible as the screen closes long before the table is unloaded.

FxMorin commented 3 years ago

Has this been fixed or is the change only client-side. If it's only client-side I could attempt to make a fix.

altrisi commented 3 years ago

According to #20, that fixed this. I'd assume it's fixed since #20 was merged.