search

gnembon / carpet-autoCraftingTable

autoCraftingTable extension for carpet-mod
GNU Lesser General Public License v3.0
80 stars 27 forks source link

Add polymer-reg-sync-manipulator to fix compat for clients with Fabric API but not this mod installed #72

Closed j5155 closed 7 months ago

j5155 commented 1 year ago

According to https://github.com/gnembon/carpet-autoCraftingTable/issues/67#issuecomment-1586386652 this should fix the compatibility issue. I was having some trouble verifying that this worked so if someone who experienced the issue can check this it would be much appreciated. Closes #67

altrisi commented 1 year ago

I think you have to call some method on it to register the block to not be synced, though I haven't used this library so I don't really know.

j5155 commented 1 year ago

That makes a lot of sense; I looked into it more and it seems you have to register it as server only using https://github.com/Patbox/polymer/blob/3a4d3c16cbbefcd69ae2b6d574b3098e7820904c/polymer-reg-sync-manipulator/src/main/java/eu/pb4/polymer/rsm/api/RegistrySyncUtils.java#L27, with an example at https://github.com/samolego/Taterzens/blob/8b0a332a715764240c7a856178c58bcfa23071a5/fabric/src/main/java/org/samo_lego/taterzens/fabric/TaterzensFabric.java#L47 Will work on implementing this later but converting this to draft for now Edit: implemented

j5155 commented 7 months ago

Looks like Gnembon "upstreamed" this mod into Minecraft official lol