gnembon / carpet-extra

Extra Features for Carpet Mod
GNU Lesser General Public License v3.0
294 stars 61 forks source link

Removed rule `updateSuppressionCrashFix` #237

Closed Fallen-Breath closed 3 years ago

Fallen-Breath commented 3 years ago

Removed rule updateSuppressionCrashFix to avoid conflicting with fabric-carpet >=1.4.49

Stuffs to be discussed:

altrisi commented 3 years ago

I don't think someone would randomly decide to update carpet extra only and not carpet tbh, I'd drop the version requirement.

Fallen-Breath commented 3 years ago

I don't think someone would randomly decide to update carpet extra only and not carpet tbh, I'd drop the version requirement.

The version requirement doesn't affect anything in your situation (both mods get updated) btw.

altrisi commented 3 years ago

My point there being, it's more likely for someone to just decide to add carpet extra to an existing carpet installation, where they would not be relying on the rule existing in one of the mods, but that would crash if they had an old carpet version.