search

gnembon / carpet-extra

Extra Features for Carpet Mod
GNU Lesser General Public License v3.0
291 stars 62 forks source link

Rules StraySpawnInIgloo and CreeperSpawnInJungleTemples broken #243

Closed MeeniMc closed 1 year ago

MeeniMc commented 2 years ago

Rules StraySpawnInIgloo and CreeperSpawnInJungleTemples do not work.

Versions

Gradle built future branch (also observed in prior releases, not sure how far back though)

commit 65d6745555a0346cd9c033b3236ee6bf33a6ec33 (HEAD -> future, origin/future)
Author: gnembon <gnembonmc@gmail.com>
Date:   Tue Nov 30 19:15:03 2021 +0100

    1.18

Replication steps

  1. git checkout 65d6745555a0
  2. ./gradlew runclient
  3. /locate junglePyramid
  4. /tp x y z and move inside the pyramid
  5. /carpet carpets
  6. use a pink carpet (a variety of mobs can spawn)
  7. /carpet CreeperSpawnInJungleTemples true
  8. use a pink carpet (result unchanged)

Notes

Rule HuskSpawnInDesertPyramids works as intended, the result of the pink carpet shows that only Husks can spawn after the rule is activated.

MeeniMc commented 1 year ago

This is actually due to the boundaries of structures being computed wrong in carpet, see https://github.com/gnembon/fabric-carpet/issues/1699