search

gnembon / carpet-extra

Extra Features for Carpet Mod
GNU Lesser General Public License v3.0
291 stars 62 forks source link

1.18.2 Broken AccurateBlockPlacement #248

Closed aria1th closed 2 years ago

aria1th commented 2 years ago

ServerPlayerNetworkHandler now checks if all( HitVec - BlockPos center < 1). Carpet Extra should mixin this to bypass check, or implement other way... now we can't use modified X values to tell server something.

maltreuter commented 2 years ago

I have this issue on my server when I try to use tweakeroo's flexibleBlockPlacementRotation.

output from server console:

Server thread/ Ignoring UseItemOnPacket from USERNAME: Location (-445.0, 69.0, 125.14848057925701) too far away from hit block class_2338{x=-451, y=69, z=125}.

fabric-carpet 1.4.66 v220228 carpet-extra 1.4.64

JarheadHME commented 2 years ago

This is the commit masa used to fix it in tweakeroo if it helps

maruohon commented 2 years ago

I have PRs prepared to fix this, and also to update the accurate placement implementation to use the same code as Tweakeroo does. I just need to still test it on a local server to make sure it works properly before I submit the PRs.

MasteredRed commented 2 years ago

I just want to ask. Did the issue with accurate placement ever get fixed?

maruohon commented 2 years ago

@MasteredRed The PRs are still open. There is a fixed build linked in this comment: https://github.com/gnembon/carpet-extra/pull/251#issuecomment-1075025541

altrisi commented 2 years ago

This issue has been fixed in latest release (note that it's not in curseforge because an error during release, but you can get it on github releases).