gnembon / carpet-extra

Extra Features for Carpet Mod
GNU Lesser General Public License v3.0
291 stars 62 forks source link

Some property names are misleading #289

Open ehx-v1 opened 1 year ago

ehx-v1 commented 1 year ago

...due to describing features that are already in the game (but done differently by the property).

To clarify: This is not to discredit the property options as good alternatives. It's just that the name can be confusing to some players (if they don't read the Readme), who might think setting them to false disables the Vanilla option whereas in reality, setting them to true enables a new option.

The affected properties:

altrisi commented 1 year ago

The problem is that renaming them would mean that any worlds that have them enabled would get them disabled, likely breaking stuff in them.

There's currently no system to automatically migrate rules to new names.

ehx-v1 commented 1 year ago

Well, that just means the issue is dependant on establishing such a system (e.g. an API version setup with backwards compatibility mixins) beforehand. Such a system would probably be helpful either way, as being able to rename properties between versions is a major plus in general. Plus, it's not like this issue is very likely to be high priority, so taking your time really is an option.