search

gnembon / carpet-extra

Extra Features for Carpet Mod
GNU Lesser General Public License v3.0
293 stars 62 forks source link

1.21.3 Support #332

Open TheUnknownCod3r opened 3 weeks ago

TheUnknownCod3r commented 3 weeks ago

Update required for 1.21.3, tested using the Fabric Overrides to bypass version requirement, spits out the Mixin Error FlowerPotBlockMixin, about onActivate. Error Below:

[16:58:46] [main/ERROR]: Mixin apply for mod carpet-extra failed carpet-extra.mixins.json:FlowerPotBlockMixin from mod carpet-extra -> net.minecraft.class_2362: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on onActivate could not find any targets matching 'Lnet/minecraft/class_2362;method_55765(Lnet/minecraft/class_1799;Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_9062;' in net/minecraft/class_2362. Using refmap carpet-extra-refmap.json [INJECT_PREPARE Applicator Phase -> carpet-extra.mixins.json:FlowerPotBlockMixin from mod carpet-extra -> Prepare Injections -> handler$bae000$carpet-extra$onActivate(Lnet/minecraft/class_1799;Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;Lnet/minecraft/class_2680;)V -> Parse -> -> Validate Targets] org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on onActivate could not find any targets matching 'Lnet/minecraft/class_2362;method_55765(Lnet/minecraft/class_1799;Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_9062;' in net/minecraft/class_2362. Using refmap carpet-extra-refmap.json [INJECT_PREPARE Applicator Phase -> carpet-extra.mixins.json:FlowerPotBlockMixin from mod carpet-extra -> Prepare Injections -> handler$bae000$carpet-extra$onActivate(Lnet/minecraft/class_1799;Lnet/minecraft/class_2680;Lnet/minecraft/class_1937;Lnet/minecraft/class_2338;Lnet/minecraft/class_1657;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;Lnet/minecraft/class_2680;)V -> Parse -> -> Validate Targets]

TheUnknownCod3r commented 3 weeks ago

Theres actually more wrong than just the one Mixin, but needs an update regardless.

sakura-ryoko commented 2 weeks ago

You can't force mods to work in newer than expected versions when code changes are needed. See my PR, and try that out.

https://github.com/gnembon/carpet-extra/pull/333

TheUnknownCod3r commented 2 weeks ago

You can't force mods to work in newer than expected versions when code changes are needed. See my PR, and try that out.

333

Never intended to force it, just wanted to see where the error lay so I could take a look, and at least let the devs know if they didn't already. Apologies if it came off that way. I'll make a copy of our server, and add the build to it in the morning, and let you know how it runs.

sakura-ryoko commented 2 weeks ago

Sounds good; it is freshly experimental, until proven, of course.

TheUnknownCod3r commented 2 weeks ago

Seems to work fine for me, although im only using Dispensers for Shears right now, so can't comment on anything dispenser related. I appreciate you taking the time to update, Sakura :)