gnembon / fabric-carpet

Fabric Carpet
MIT License
1.7k stars 270 forks source link

[Bug] `draw` command's NBT comparing is broken #1369

Open Crec0 opened 2 years ago

Crec0 commented 2 years ago

I will be using furnace as an example for all the bugs however it works for all blocks with NBT. These are all NBT related, so making an single issue.

Testing was done in a void world, 22w11a snapshot

Fail to replace

If draw command is used to replace existing furnace with no NBT with furnace with NBT, it will not replace it.

Steps to reproduce

Invalid NBT

If a valid NBT furnace is replaced with invalid NBT furnace, it reports 0 furnaces filled however it still replaces them all.

Steps to reproduce

Fail to replace with valid NBT

It's very similar to the one above however just with valid nbt this time. Even the same nbt fails.

Steps to reproduce

Succeeds to replace all furnaces correctly for some odd unknown reason

If furnaces are lit, it will somehow manage to replace them all, which is odd. (Only works for furnace, didn't test other blocks with NBT) Btw, furnaces are only lit, not actually smelting. (Another bug?)

Steps to reproduce

Crec0 commented 2 years ago

First 3 are very clearly linked together and might be because of same bug. 4th is confusing