Closed aria1th closed 11 months ago
No rule checks there, does this affect vanilla behaviour? Or does this only run with the rule on?
Also throw something (like new AssertionError
) on static shadows please (unless I'm confusing them with something else).
@altrisi for normal cases, it should not be affected, but there might be some cases that could be inconsistent
I'll do some check in 24 hours.
Some inspections: to NOT register static value and prevent some exceptions, instead of current code, the code should be modified as:
inject getHeightmapType, checkSpawnRules function instead.
This was the minimal change required to prevent piglin brutes spawning in air - but it may prevent some new chunk piglin brute generation... but rule itself is already changing the behavior so it shouldn't matter, right? @altrisi
As long as it only affects behaviour when the rule is on, and with it on it doesn't like severely like reduce base structure spawns (changes significantly "how it feels" (?) going normally through a bastion) or something it's fine for me.
Fixes https://github.com/gnembon/fabric-carpet/issues/1546
The core cause was Piglin Brutes not having spawn condition, allowing it to pass every check except 'damage'.
This patch registers spawn condition check for piglin brutes.
This does not mean they will spawn in overworld / elsewhere, since spawn requires mob list entry first.