gnembon / fabric-carpet

Fabric Carpet
MIT License
1.65k stars 261 forks source link

Permissions API support concept 2 #1864

Open altrisi opened 5 months ago

altrisi commented 5 months ago

Prototype on supporting the fabric permissions API for Carpet commands. It'd only be used if the permission manager is present, so it's not required/included otherwise.

TBD:

TODO:

Maybe future enhancements:

Note that I don't know a lot about the permissions api stuff, barely used it a similar one many years ago.

Fixes #1850.

sakura-ryoko commented 5 months ago

Hey, nice work. I just wanted to mention that there are additional versions of fabric-permissions-api that are fairly common to use. Take a look at implementing a check for Drex's fork, as he is implementing it in a bunch of popular mods that he contributes code for. https://github.com/DrexHD/fabric-permissions-api This fork keeps the same name, but bumps the version to 0.3 .

altrisi commented 5 months ago

As far as I know that 0.3 is compatible with mods depending on the original, so given Carpet wouldn't actually include the API (just use it if it's there), the idea is it'd be compatible with either out of the box.