gnembon / fabric-carpet

Fabric Carpet
MIT License
1.63k stars 260 forks source link

Fix CarpetClient not disconnecting when leaving multiplayer #1913

Open altrisi opened 1 month ago

altrisi commented 1 month ago

Fixes #1908.

The issue was that the new transfer packets changed the signature of the disconnect method, but left a shortcut with the old one, that is no longer called when disconnecting. This should also make Carpet work properly when the client is being transferred between Carpet/non-Carpet servers (or just with different rules).

This removes the ClientCommonPacketListenerImpl mixin given it seems to not do anything anymore, and it was added with the network refactor.