gnembon / fabric-carpet

Fabric Carpet
MIT License
1.63k stars 260 forks source link

Unfreeze game tick when player just logged in will cause the client still show things freezed. #1924

Open Eyre-S opened 1 week ago

Eyre-S commented 1 week ago

I am making a small extension and implemented a feature that can automatically freeze the game when no players is online for my dedicated server.

I am already done the feature and tested with the debug server and a vanilla client.

But when I am trying to add this to my mod-pack (which have carpet in both server and client), I found that when I joined the server, the game tick is un-freezed and normally ticking, but the client seems still considering the server is in freezing state, caused everything looks like frozen in client (for example, the entities do not move at all in client). But when I join the same server without carpet mod, it just runs normally.

Here is the related code I just wrote: https://github.com/suk-ws/carpet-nukos-addition/blob/master/src/main/java/cc/sukazyo/nukos/carpet/ticks/AutoTickFreeze.java.

And I find an old issue (https://github.com/gnembon/fabric-carpet/issues/550) in this repository, it gives a scarpet script that implemented the same feature. I started a new server with only farbic-loader, carpet mod, and the scarpet script. With this server and a client that only contains fabric-loader, carpet mod, I can still reproduce this problem, and with the vanilla client is all ok. (both modded client and server contains only fabric-loader without fabric-api)

My game version: 1.20.1 Fabric loader version: 0.15.11 Carpet version: 1.4.112+v230608

Server log: latest.log Client (with carpet) log: latest.log Client (vanilla) log: latest.log

lansantuyo commented 1 week ago

Thanks for this. I was trying to find the cause for almost two days now, and I never would have thought that having carpet on the client was the one causing the issue.