gnembon / scarpet

Public Repository of scarpet programs for Minecraft
Creative Commons Zero v1.0 Universal
351 stars 157 forks source link

Updated auto_ligher.sc to new 1.18+ light level #296

Closed Ghoulboy78 closed 2 years ago

Ghoulboy78 commented 2 years ago

I added it as a global variable so you can change based on the version you're playing on. Should I use system_info to check automatically though? I also added a boolean for lighting the ground cos some people want that too.

CommandLeo commented 2 years ago

Should I use system_info to check automatically though?

Yes, support for 1.17 (and 1.16) should always be implemented whenever it's easily doable.

Firigion commented 2 years ago

The preading now works. However, it still doesn't light up the surface od the world for me, and I have no idea why (I double checked the logic, it looks good to me?). Dod the other reviewers get their ground torched (:fire:)?

Ghoulboy78 commented 2 years ago

@Firigion That could be because you're running it during the daytime? Or maybe u forgot to turn that setting?