gnewton / chidley

Convert XML to Go structs / XML to JSON
Apache License 2.0
274 stars 35 forks source link

Add charset detection to decoder #17

Open i39 opened 7 years ago

i39 commented 7 years ago

Add charset detection for remove errors like this: extractor.go:58: xml: encoding "windows-1251" declared but Decoder.CharsetReader is nil

gnewton commented 7 years ago

Hello,

Sorry to be so slow to respond.

I checked out https://github.com/i39/chidley and when I did 'go build' got these errors:

$ go build
# _/home/gnewton/tmp/g/chidley
./extractor.go:42: undefined: charset.NewReaderLabel
$

I will look at your suggested solution and see if I can implement it.

Thanks, Glen