search

gnghskhn / recursive-ascent

Automatically exported from code.google.com/p/recursive-ascent
0 stars 0 forks source link

Bad key for ExpandMeta rules #60

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
ExpandMeta conversion stores already expanded rule to deal with recursion and 
mimnimizing the rules count.
ToString method is currently used to get key. This is bad, because it's 
implementation can change, and conversion won't work correctly (and it has 
already happened before).
Possible solutions.
  1. Use hash function. It works, but grammar become bigger.
  2. Current implementation of getting a key may be dirrectly wiritten in ExpandMeta.

It's not clear if current key-evaluating function is correct. The same problem 
with hash function.

Original issue reported on code.google.com by dimo...@gmail.com on 2 Sep 2012 at 1:34

GoogleCodeExporter commented 8 years ago 
Key is now really custom function. But it's correctness is still very deniable.

Original comment by dimo...@gmail.com on 10 Oct 2012 at 1:14