code cleanup and zero warnings

gngrOrg / gngr

a cross-platform browser focussed on privacy.

https://gngr.info

283 stars 60 forks source link

code cleanup and zero warnings #168

Open hrj opened 8 years ago

hrj commented 8 years ago

The goal is to reduce the number of warnings being shown in Eclipse, and to enable more such code-smells to be discovered.

Current status

Burnt down number of warnings from 200+ to 156.
Enabled null annotation analysis in Eclipse. This has helped track a few bugs already, and has also helped optimisation by reducing the number of null checks.

hrj commented 8 years ago

Down to 79 warnings.

Apart from cleanups, also changed the eclipse settings for warnings (some are now more strict and some are now ignored). I need to save / document the settings in the wiki.

hrj commented 8 years ago

And ... we are down to 49 warnings as of latest master.

hrj commented 8 years ago

The current master has 42 warnings. Further improvements in next milestone.