search

gngrOrg / gngr

a cross-platform browser focussed on privacy.
https://gngr.info
287 stars 60 forks source link

Add #171 #239

Closed jtprichett closed 3 years ago

jtprichett commented 7 years ago

Add #171: Support for accepted and rejected requests. Currently set to simple counters, serialized into an array that is passed to the Request Manager GUI. Then displayed as text objects.

hrj commented 7 years ago

Thanks @JoshuaTPritchett, this is a great start. Few comments:

jtprichett commented 7 years ago

@hrj I am not sure what you mean, currently, if a user types www.google.com then it would display all of the accepted requests and all of the rejected requests. This is being displayed after you click on the request manager button. Every time a user makes a new domain request, the counters are reset and updated for the new page.

hrj commented 7 years ago

This is being displayed after you click on the request manager button.

The goal is to display those numbers before clicking. So I imagine them to be shown on the button itself, not in the dialog.

hrj commented 6 years ago

@JoshuaTPritchett Thanks for your work. I am sorry I didn't respond earlier. For one, github doesn't notify me when you update the PR, and secondly, I had just joined a new project in July, and forgot to follow up here.

The changes look good and ready to merge.

Would it be possible for you to sign the CLA? If not, I am willing to consider other alternatives such as Developer Certificate of Origin.

hrj commented 6 years ago

To make contributions easier, we are changing our policy to support Developer Certificate of Origin (DCO) and not requiring a CLA anymore. DCO is becoming the new standard used by many open-source projects including the Linux Kernel and GNOME.

See our Contributing Guide for more info about DCO.

hrj commented 3 years ago

Thanks @JoshuaTPritchett

But I can't merge without DCO 😢