gnieboer / GNURadio_Windows_Build_Scripts

A series of Powershell scripts to automatically download, build from source, and install GNURadio and -all- it's dependencies as 64-bit native binaries then package as an msi using Visual Studio 2015
GNU General Public License v3.0
89 stars 32 forks source link

Dependency Tests are only testing for directories #3

Closed noc0lour closed 6 years ago

noc0lour commented 8 years ago

Hey, first of all: Thanks for the great work on making GNU Radio run on Windows and providing mostly easy to use installation scripts. First thing I'm running into: The setup.ps1 script often is only testing "default" installation directories for dependencies. A slight non default configuration of your system throws errors. Maybe we could provide with some "sophisticated" dependency checking, but unfortunatly I'm not that good in development for Windows.

A start could be not failing but asking for alternative installation directories for cmake, perl... and adding them to the alias?

gnieboer commented 8 years ago

Yep, thanks for the input. Legit concern, will consider alternative detection methods for future upgrades.

noc0lour commented 8 years ago

Maybe I'll add the changes soon. I'm still trying to convince my Windows 8.1 to compile GNU Radio for me. But I'm seeing the light from the other side.

naikrovek commented 7 years ago

This may help you detect that the required commands are in the path, without checking specific directories for those commands: https://blogs.technet.microsoft.com/heyscriptingguy/2013/02/19/use-a-powershell-function-to-see-if-a-command-exists/

It works for executables as well as cmdlets.

gnieboer commented 6 years ago

Switched checks to use Get-Command and set aliases more robustly. Thanks!