search

gnif / LookingGlass

An extremely low latency KVMFR (KVM FrameRelay) implementation for guests with VGA PCI Passthrough.
GNU General Public License v2.0
4.64k stars 257 forks source link

Update udev rule in module.rst #1082

Closed f-fouad closed 1 year ago

f-fouad commented 1 year ago

Udev rules accept UIDs. Use that to have a functional snippet by default and prompt to change if necessary.

netboy3 commented 1 year ago

I don't see the advantage in this change. Assuming every system will have its active user as the first created user and that user's UID is 1000 is not necessarily correct. UIDs are more confusing to users than usernames. A better choice, in my opinion, to make a more KISS solution for this is to remove the OWNER parameter and add a TAG+="uaccess" parameter. This will use the systemd currently logged-in user to apply dynamic ACL to the udev node.

gnif commented 1 year ago

Agreed, and for such a small change, this should have been discussed with @JJRcop directly instead of a PR. Closing, if you wish to pursue this please make it a feature request, or talk to us in discord.