search

gnif / LookingGlass

An extremely low latency KVMFR (KVM FrameRelay) implementation for guests with VGA PCI Passthrough.
GNU General Public License v2.0
4.64k stars 257 forks source link

[client] wayland: support back/forward buttons on some mouses #1087

Closed MakiseKurisu closed 1 year ago

MakiseKurisu commented 1 year ago

Despite their names, SPICE_MOUSE_BUTTON_SIDE and SPICE_MOUSE_BUTTON_EXTRA are actually treated by Windows as BTN_BACK and BTN_FORWARD, with Edge browser and Heroes of the Storm both recognize them and label them correctly.

Add the missing mapping for BTN_BACK and BTN_FORWARD.

This is hinted by [1].

1: https://github.com/rust-windowing/winit/issues/1914#issuecomment-826087457

gnif commented 1 year ago

Sorry but this doesn't make much sense to me, we are already aware of how windows treats these buttons and we have many Wayland users already making use of the side buttons on their mice without issue.

If you have hardware sending different event codes, this seems to be either an upstream bug or a bug with your hardware. If we implement the above change it may start breaking behaviour on other mice that use these event codes for other different buttons.

@quantum5 can you please look at this, I am not keen to just change this without confirming it wont cause issue first.

MakiseKurisu commented 1 year ago

After some testing I'd say you are probably right. I use Piper and I was having issue with side buttons that I had to create a different mouse profile to bind those buttons to keyboard keys to get registered inside LG host. I did full system upgrade before working on this PR to install some dependencies and now the issue resolves itself, and my test result is likely due to this instead of my PR. I retested with the latest stable LG and it is working as intended.