search

gnif / LookingGlass

An extremely low latency KVMFR (KVM FrameRelay) implementation for guests with VGA PCI Passthrough.
GNU General Public License v2.0
4.75k stars 261 forks source link

[client] wayland: Use full buffer for wayland viewport source #1115

Closed kamplom closed 8 months ago

kamplom commented 8 months ago

Prevents the client from crashing when using factorial scaling in Wayland. See https://github.com/libsdl-org/SDL/issues/9283#issuecomment-2002501376 for technical explanation. Fixes https://github.com/gnif/LookingGlass/issues/1113. Tested with hyprland and plasma on wayland.

gnif commented 8 months ago

Thanks but you need to make a few changes.

  1. This project has adopted an 80 column width limit, please adjust your patch to conform to this.
  2. Please add yourself to the AUTHORS file as a requirement of contributing.
  3. Please adjust the commit format to conform with the project, in this case it should read [client] wayland: ...
gnif commented 8 months ago

I am sorry, while you have made the requested changes it has been done improperly.

  1. Please squash your changes into a single commit (hint: git rebase -i)
  2. Please adjust the comment message of your changes, not the title of this issue (hint: git commit --amend)

As this is a fork of the project you can force push to it (git push -f) which will update this PR accordingly

kamplom commented 8 months ago

Should be OK now. Thanks for taking your time to explain the proper way to do it, and sorry for the inconvenience