search

gnif / LookingGlass

An extremely low latency KVMFR (KVM FrameRelay) implementation for guests with VGA PCI Passthrough.
GNU General Public License v2.0
4.66k stars 257 forks source link

[client] egl: remove extra samplers #953

Closed hollinsky closed 2 years ago

hollinsky commented 2 years ago

There was an unused sampler in TextureBuffer, any time it was bound it used the base->sampler instead.

The real point of this, however, is the sampler in the EGL Desktop. If I understand correctly, the desktop doesn't need its own sampler. There is already an identically configured one in the desktop->texture.

For some reason, using the texture sampler fixes a black screen issue caused by f0ea882 (where the separate desktop sampler was added) with my GTX 660 using the 470.86 driver. Maybe hitting some limit for how many samplers can be allocated?

gnif commented 2 years ago

Changes look sane, I will look a bit deeper into this before committing though. Thanks for identifying the issue, could this perhaps be related to https://forum.level1techs.com/t/looking-glass-b5-01-fsr-issues/181625 ?