search

gnikyt / Basic-Shopify-API

A simple API wrapper for Shopify using Guzzle for REST and GraphQL
MIT License
220 stars 66 forks source link

ResponseAccess::current() should be compatible with Iterator::current() #129

Closed HugoHeneault closed 2 years ago

HugoHeneault commented 2 years ago

Hi there,

Thanks for this great API!

I had a few error messages using PHP 8.1 like Return type of Osiset\BasicShopifyAPI\ResponseAccess::current() should either be compatible with Iterator::current(): mixed

This fixes it :)

chrisnetonline commented 2 years ago

@osiset Any chance we can get this merged? We're noticing this deprecation error since switching to PHP 8.1.

HugoHeneault commented 2 years ago

I'm not using it on PHP 8.1 anymore but I think there are more cases I haven't fixed. Feel free to update my PR :)

abishekrsrikaanth commented 2 years ago

@osiset any chance this can be merged?

JoshHighland commented 2 years ago

Verified, this PR solves the depreciation issues with php 8.1. Please merge

bretto36 commented 2 years ago

@osiset Is there anyone who can marge these changes if you're too busy at the moment?

MrDellimore commented 2 years ago

@osiset Hi is there anything stopping this from being merged?