search

gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

added laravel 9 #1090

Closed Sanjay-100 closed 2 years ago

Sanjay-100 commented 2 years ago

Update composer file compatible with laravel version 9

lucasmichot commented 2 years ago

CI is broken, please fix it @Sanjay-100 Also please this in the tests strategies

lucasmichot commented 2 years ago

Ping @Sanjay-100

Kyon147 commented 2 years ago

Just adding the || 9.0 to composer probably won't be enough. Tests will need to be updated and we will need to make sure that there are not any high / medium impact changes https://laravel.com/docs/9.x/upgrade

One of them is going to be the requirement to be on at least php 8.0.2 so the CI/CD flows might need to be amended.

As @lucasmichot mentioned, @Sanjay-100 can you update your PR as it is broken.

lucasmichot commented 2 years ago

Closed by #1100