Adding support for Laravel 9

lucasmichot commented 2 years ago

Thanks @steveperrycreative , can you also add the associated version in the CI strategy ?

steveperrycreative commented 2 years ago

Yes @lucasmichot I'll take a look when I get chance.

Thanks.

lucasmichot commented 2 years ago

I have added them @steveperrycreative

lucasmichot commented 2 years ago

Closes #1090

adrianmihaila commented 2 years ago

@osiset can you please help us with a review?

litalboa commented 2 years ago

@osiset can you please merge and approved it?

kamalpal commented 2 years ago

@osiset Please review it.

jamescowie commented 2 years ago

I tested this branch and when trying to publish the config I get:

 php artisan vendor:publish --tag=shopify-config
No publishable resources for tag [shopify-config].

I'm using composer repositories to ensure I get your branch with Laravel 9 fixies in place.

Is this expected or I am missing something, going to dive into this part shortly to see if it was me.

rizwanWixpa098 commented 2 years ago

@osiset Hello, I'm trying install osiset package on laravel 9 but I'm having errors. Have you added the support for laravel 9

abubakar0101 commented 2 years ago

osiset still not install on laravel 9 and give error below

**### Your requirements could not be resolved to an installable set of packages. Problem 1

Root composer.json requires osiset/laravel-shopify ^17.1 -> satisfiable by osiset/laravel-shopify[v17.1.0, v17.1.1, 17.1.x-dev].
osiset/laravel-shopify[v17.1.0, ..., 17.1.x-dev] require laravel/framework ^7.0 || ^8.0 -> found laravel/framework[v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but it conflicts with your root composer.json require (^9.11).**

rizwanWixpa098 commented 2 years ago

I tried to install v17 of osiset but got these errors as well

zulunran commented 2 years ago

@osiset I am facing a problem to installing ossiset package version 17 and 16 in laravel 9

lucasmichot commented 2 years ago

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

abubakar0101 commented 2 years ago

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

Yes this package does not yet support Laravel 9.x and not install on laravel 9

zulunran commented 2 years ago

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

this package is not supported yet for larave9

lucasmichot commented 2 years ago

Yes, as of this PR implementing Laravel 9.x support is obviously still open.

When Tyler will have reviewed it, it will be merged and a new release will be created. Meanwhile you can also probably use your own fork of this repository.

zulunran commented 2 years ago

thanks for responding how long it will take to reviewed by @Tyler

rizwanWixpa098 commented 2 years ago

@rizwanWixpa098 @abubakar0101 @zulunran

Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

I'm having problem with installation of package in laravel 9 so I wanted to know either the package support laravel 9 or not??

lucasmichot commented 2 years ago

thanks for responding how long it will take to reviewed by @tyler

Tyler, not @tyler

I don't know when, we all have day jobs and family chores

lucasmichot commented 2 years ago

@rizwanWixpa098 @abubakar0101 @zulunran Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

I'm having problem with installation of package in laravel 9 so I wanted to know either the package support laravel 9 or not??

If this PR is not merged, then it does not support Laravel 9.x

rizwanWixpa098 commented 2 years ago

@rizwanWixpa098 @abubakar0101 @zulunran Are you reporting a problem especially with this branch ? Or just the fact that this package does not yet support Laravel 9.x ?

I'm having problem with installation of package in laravel 9 so I wanted to know either the package support laravel 9 or not??

If this PR is not merged, then it does not support Laravel 9.x

Okay Thanks for your response

smartdatasoft commented 2 years ago

Hello, any update for review and approval it. How can we use the test package thank you

francescomalatesta commented 2 years ago

Hi, is there any news about this? May I help somehow? Would love to use it with my next app! :) Thanks for all your work on this package, it's a real game-changer for me.