search

gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Fix when we try to reauth scopes #1139

Closed Kyon147 closed 2 years ago

Kyon147 commented 2 years ago

This PR brings back the full page reauth because when you update the api scopes after install you will run into the iframe error as it is set to deny.

Kyon147 commented 2 years ago

@osiset I found an issue with my previous implementation that happens when you try to reauth an app. Usually when requesting new permissions after the first install.

I've brought back the full page redirect but updated it to use the app bridge implementation. As that is what Shopify does recommend https://shopify.dev/apps/tools/app-bridge/getting-started#authorize-with-oauth

Kyon147 commented 2 years ago

As a side note but connected to this.

We do need to fix the OAUTH flow as the current way where you hit /auth/token after accepting the install gets flagged in review for public apps as they expect the merchant to hit the home route (UI) right after and are very strict with it.

image

Kyon147 commented 2 years ago

Closing in favor of https://github.com/osiset/laravel-shopify/pull/1097