search

gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Propose to fix Billable app throwing exception on install #1145

Closed thang12l closed 2 years ago

thang12l commented 2 years ago

Fix PHP 8.0: Deprecate required parameters after optional parameters in function/method signatures

Kyon147 commented 2 years ago

@osiset going to merge this one (later) in too for the upcoming release as php8.1 is being used more and more and this fix stops the billing route breaking as the optional param needs to be at the end of the method.