search

gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Token verification creates redirect loop #1179

Open npabisz opened 2 years ago

npabisz commented 2 years ago

I just discovered that one on my apps has issue with token verification which makes redirect loop for x seconds for the first time app is opened. I'm talking about src/Objects/Values/SessionToken.php#269 which was triggering assertion. What I found out was that my server had not synchronized time. Steps to fix:

sudo apt install systemd-timesyncd
sudo systemctl start systemd-timesyncd

However maybe there should be some warning/error saying that there is issue with time instead of tons of redirects.

Kyon147 commented 2 years ago

hi @npabisz

Good catch, are you up for creating a PR with a potential solution?