search

gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

(Pinned) Non-embed App Support #1208

Open Kyon147 opened 2 years ago

Kyon147 commented 2 years ago

Hi all,

There's a lot of issues that get created overtime asking about "non-embed app" support or issues that say it is not working etc.

Currently the package does not support non-embedded apps and if you submit to Shopify as a non-embed app using this package you will likely get rejected. If you are using this package at the moment, you can only use it as an embedded app.

There is an older PR #929 and #935 which is the current progress of that feature for this package. Anyone is welcome to read through and create this feature if they wish - we'd love a PR to review for someone that wants the feature and is willing to implement it for the community.

Please submit any questions, support, improvements etc about non-embed in this ticket or as a discussion.

Moving forward, all non-embed issues will be closed to keep the issues queue tidy.

Thanks for your understanding.

Kyon147 commented 2 years ago

Related Issues.

16

354

861

1112

varrwillis commented 2 years ago

The actual PR that @xplodedthemes created is here #935.

I have implemented it myself as a test and was marginally successful, but it doesn't feel very solid.

I also wasn't aware of Shopify rejecting non-embedded apps using this library, thank you for mentioning that. That kind of makes my decision easier.

I myself would love if this library gets non-embedded capability, but for the time being I will need to resort to implementing features directly in my own library instead.

Kyon147 commented 2 years ago

Thanks @varrwillis - updated my original post to include that PR too.

There's no direct response from Shopify, but I have just seen comments from other users who have set up using this package and trying to use it non-embed. They are being rejected likely because the auth flow and AppBridge is slightly different when not loading it within the shopify admin and as mentioned, it does not have support yet.

We are happy for someone to take on the work for getting non-app embed support, if there is someone who wants to open up their own PR. So if you do resort to implementing it yourself, feel to open up one 👍