search

gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Removed `!!` from the full_page_redirect breaking authenticate route #1222

Closed Kyon147 closed 1 year ago

Kyon147 commented 1 year ago

Currently the authenticated route can break usually on a proper visit to /authenticate because of the {{!! !!}} formatting in the blade template for the api key, shop origin and host.

Kyon147 commented 1 year ago

@osiset a little bit of a hotfix as the auth route is currently broken when accessing it directly.

gnikyt commented 1 year ago

@Kyon147 It seems testbench-core introduces static properties. Specifically here, but its not declared in the class head, resulting in and error for PHP 8.

Edit: It was literally added 10 hours ago. Seems like its trying to set lastResponse, but its not defined anywhere. Do we need to define it in TestCase.php of our package? Like... public static $latestResponse = null; ?

Kyon147 commented 1 year ago

It was literally added 10 hours ago. Seems like its trying to set lastResponse, but its not defined anywhere. Do we need to define it in TestCase.php of our package? Like... public static $latestResponse = null; ?

Yeah that is totally weird, I'll take a look but defining it in our test case sounds like a good idea for now!

Kyon147 commented 1 year ago

@osiset that has fixed the error for now in the tests - not sure why codecov is complaining about files not even touched in my PR though....