search

gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Added parameter to billing process #1235

Closed RishabhTayal closed 2 years ago

RishabhTayal commented 2 years ago

When a merchant accepts/declines billing this will add a parameter 'billing -> success' to the home page route. This way developers can detect when billing is accepted/declined.

gnikyt commented 2 years ago

@RishabhTayal Good idea, thanks for this. Can you add a test to the BillingController's test file to confirm this works as expected? You can modify the existing tests thats in the file already for accept/decline and test the result of the redirect URL.

RishabhTayal commented 2 years ago

@osiset I am very new to php and laravel environment. Could you please point me where and what I need to change in the BillingControllerTest.php class?

gnikyt commented 2 years ago

@RishabhTayal You should be able to assert the parameter comes back on this test

RishabhTayal commented 2 years ago

@osiset Sorry for naive question: Do you have an example in the code of asserting a parameter?

Kyon147 commented 2 years ago

@osiset I'm assuming this PR is the one you mentioned, I can merge this one and my on together once they are both ready and they can go out together. I'll sort the test out @RishabhTayal.

gnikyt commented 2 years ago

@Kyon147 This is exactly it, yes!

Kyon147 commented 2 years ago

Closing in favour of #1244