gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Infinite loop when installing custom app with MS Edge #675

Closed pontifex closed 3 years ago

pontifex commented 3 years ago

Expected Behavior

The app extension is installed. Infinite loop is not happening. "itp" cookie is set.

Current Behavior

When I click "Install app" in Shopify partner dashboard, an infinite loop starts. It seems to be caused by missing "itp" cookie.

Failure Information

Read from bottom to top (bottom goes first) and so on, I stop it manually

GET /                   302 Found
GET /itp                    302 Found
GET /authenticate/oauth     200 OK
GET /                   302 Found
GET /itp                    302 Found
GET /authenticate/oauth     200 OK
GET /                                       302 Found 
GET /itp                                   302 Found 
GET /authenticate/oauth        200 OK   

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Create custom app on Shopify, using Laravel and your package.
  2. Try to install app from step 1 on test shop using MS Edge browser in private mode (other browsers not tested)
  3. Infinite loop starts, observe server logs, browser traffic etc.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

pontifex commented 3 years ago

@osiset Issue is fixed on https://github.com/osiset/laravel-shopify/releases/tag/v16.0.1 Closing.