gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Missing Shop Domain exception #753

Closed osamashamim7 closed 3 years ago

osamashamim7 commented 3 years ago

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

After virtual hosting running it for the first time it shows missingdomaineceptionerror

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Failure Logs

Please include any relevant log snippets or files here.

darrynten commented 3 years ago

Try AuthToken middleware with a JWT instead.

ghost commented 3 years ago

You have http. Shopify requires https.

You can add the following script to the layout, for example

<script>
    if (window.location.protocol != "https:") {
        window.location.protocol = "https";
    }
</script>
osamashamim7 commented 3 years ago

Hi,

I added this script in the welcome blade but no success.

Thank You

On Mon, Mar 29, 2021 at 11:42 PM Vitaly @.***> wrote:

You have http. Shopify requires https.

You can add the following script to the layout, for example

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/osiset/laravel-shopify/issues/753#issuecomment-809661130, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARTGJJS6RJYPOXURGL3DAXDTGDJ2VANCNFSM4Z7PIDGQ .

brucelee90 commented 3 years ago

Try to enter your URL with parameter ?shop=[your-app-name].myshopify.com

I think that's what the middleware is looking for

mumer96 commented 3 years ago

Try if($this->app) { \URL::forceScheme('https'); } in you AppServiceProvider boot method

diacu commented 3 years ago

It has nothing to do with the https. The documentation is outdated and actually there is no login page. As @brucelee90 said, you need a ?shop=[your-shop-name].myshopify.com parameter in url.

gnikyt commented 3 years ago

Cleanup... Closing for now, cookies are removed in v17.0.0 Re-open if still and issue. Thanks!