gnikyt / laravel-shopify

A full-featured Laravel package for aiding in Shopify App development
MIT License
1.24k stars 374 forks source link

Not embedded Shopify app #862

Closed abdelmoughit555 closed 3 years ago

abdelmoughit555 commented 3 years ago

Hello everyone!

Expected Behavior

I'm planning on building a non embedded Shopify but when I disabled it from Shopify app and setting SHOPIFY_APPBRIDGE_ENABLED = false when I try to install the app in my store, the page gets stuck in loading screen. The shop is registered in in my database.

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Please include any relevant log snippets or files here.

Screen Shot 2021-07-04 at 13 54 43

Thanks everyone!

abdelmoughit555 commented 3 years ago

What I noticed is that version 17 does not support auth.shopify middleware anymore. Should I use version 16 if I wanted to not use embedded Shopify app?

ghost commented 3 years ago

version 16 uses cookies, so I wouldn't recommend using it

abdelmoughit555 commented 3 years ago

version 16 uses cookies, so I wouldn't recommend using it

Thank you ! but is there a way to you version 17 without embedding my app? my app design is different that Shopify's, thats why I'm trying to not use embedded option

ghost commented 3 years ago

Thank you ! but is there a way to you version 17 without embedding my app? my app design is different that Shopify's, thats why I'm trying to not use embedded option

specifically with version 17 I didn't do this. but I'll try it tomorrow and report back, I'm curious about it myself.

khiconit commented 3 years ago

Same issue

abdelmoughit555 commented 3 years ago

Thank you ! but is there a way to you version 17 without embedding my app? my app design is different that Shopify's, thats why I'm trying to not use embedded option

specifically with version 17 I didn't do this. but I'll try it tomorrow and report back, I'm curious about it myself.

Thank you!

hamzasgd commented 3 years ago

How to solve this?

khiconit commented 3 years ago

I downgraded to ver 16 to work with non-embed app.

hamzasgd commented 3 years ago

So ver 17 will not work for embedded apps?

khiconit commented 3 years ago

I think that v17 only work with emmbed app

hamzasgd commented 3 years ago

I think that v17 only work with emmbed app

Yes I am using it with embedded but the problem is same.

abdelmoughit555 commented 3 years ago

I downgraded to ver 16 to work with non-embed app.

Can you use version 16 without Shopify rejects your app?

gnikyt commented 3 years ago

@abdelmoughit555 I believe with tokens we will be tied to AppBridge and embedded at this point. I think I will have to deprecate the setting.

abdelmoughit555 commented 3 years ago

@abdelmoughit555 I believe with tokens we will be tied to AppBridge and embedded at this point. I think I will have to deprecate the setting.

Thank you for your comment! I just wanna ask if its ok to use version 16 if i dont want my app to be embedded?

ghost commented 3 years ago

Thank you for your comment! I just wanna ask if its ok to use version 16 if i dont want my app to be embedded?

your app will most likely not pass the moderation.

and, at the very least, will not work in safari.

I've tried deploying a non-embedded app, it can be achieved quite well, but most likely you will have to use some third party solution to get the jwt tokens. and, preferably make a spa app in such a case

abdelmoughit555 commented 3 years ago

Thank you for your comment! I just wanna ask if its ok to use version 16 if i dont want my app to be embedded?

your app will most likely not pass the moderation.

and, at the very least, will not work in safari.

I've tried deploying a non-embedded app, it can be achieved quite well, but most likely you will have to use some third party solution to get the jwt tokens. and, preferably make a spa app in such a case

I'm planning on using your suggestion, I'm trying to build a spa app non-embedded using jwt token. If my app will get rejected i will switch easily to version 17 (hopefully). Thanks for your suggestion!

gnikyt commented 3 years ago

Thanks, I'll close this for now, I'll update the wiki this week to note only embedded is currently supported. If you get info on getting the tokens outside of Shopify, that'd be interesting.