search

gnir-work / react-window-dynamic-list

A naive approach to virtualizing a dynamically sized list
49 stars 9 forks source link

Calling resetAfterIndex on list instance does not affect layout #25

Closed SpadarShut closed 3 years ago

SpadarShut commented 3 years ago

The library still uses cached values after calling resetAfterIndex method of the rect-window list.

I can make a PR if you tell what's the proper way to fix it.

gnir-work commented 3 years ago

Hey, I will probably look into it tomorow. If you have the time to send a Codesandbox it will be much appreciated :)

gnir-work commented 3 years ago

Fixed in the following PR :) You can update to latest version npm i react-window-dynamic-list@2.4.0 in order to recieve the changes. I am closing the issue for now, in case something else pops up you are more than welcomed to reopen it.

SpadarShut commented 3 years ago

Great, thank you!

I found an issue, though. During npm install I get an error that this package has react 16 in peer dependencies, which conflicts with my projects's dependency on v17. Can you please add 17 (and maybe 18?) too?

UPD: To be more exact, npm complains about @types/react package. Not sure why in previous version it was ok.

UPD2: npm version is 7.19.0

gnir-work commented 3 years ago

Hey! Thanks for the feedback, Fixed in version 2.4.1 :)

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sun, Jul 11, 2021 at 4:26 PM Pavel Shut @.***> wrote:

Great, thank you!

I found an issue, though. During npm install I get an error that this package has react 16 in peer dependencies, which conflicts with my projects's dependency on v17. Can you please add 17 (and maybe 18?) too?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/gnir-work/react-window-dynamic-list/issues/25#issuecomment-877799783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKLMGSVB2QRPSS27BUCYY2DTXGLYXANCNFSM476AVQ2A .