search

gnir-work / react-window-dynamic-list

A naive approach to virtualizing a dynamically sized list
49 stars 9 forks source link

Typescript types... #8

Closed burtonator closed 4 years ago

burtonator commented 4 years ago

We need typescript types. I can submit a .ts file if you guys want. Going to test this in my app as I need it in two major places.

gnir-work commented 4 years ago

I am not sure how adding typescript will affect the build process. I will probably have time to check this out in the weekend 😊 If you want you are more than welcomed to submit a Pull Request.

On Mon, Apr 13, 2020, 18:59 Kevin Burton notifications@github.com wrote:

We need typescript types. I can submit a .ts file if you guys want. Going to test this in my app as I need it in two major places.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gnir-work/react-window-dynamic-list/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKLMGST5FDKZT4QFW2AJMG3RMMZHRANCNFSM4MHBPVMA .

JbPons commented 4 years ago

Hi,

Any news here ? I work on a project use React typescript, and I really want to use this library. I can help on Typescript type if you need it.

gnir-work commented 4 years ago

Ill probably get to it in the next few days :)

On Mon, May 18, 2020, 00:22 Jean-Baptiste Pons notifications@github.com wrote:

Hi,

Any news here ? I work on a project use React typescript, and I really want to use this library. I can help on Typescript type if you need it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gnir-work/react-window-dynamic-list/issues/8#issuecomment-629862766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKLMGSVITV52ZBNJMB624M3RSBIQTANCNFSM4MHBPVMA .

amocarski commented 4 years ago

@gnir-work any updates? @burtonator can you upload file in the meanwile?

gnir-work commented 4 years ago

First of all I am sorry for the delayed response guys, the past month was really intense for me... Luckily I had some time today so I added support for typescript 🥳.

Please run npm i react-window-dynamic-list@latest, the support is from version 2.3.5 and above.

In case any of you come across any bugs or wrong types please let me now, in the mean time I am closing the issue. Cheers 🐻