gnmearacaun / spacegray-trans.vim

This is a transparent colorscheme for LunarVim
GNU General Public License v3.0
2 stars 0 forks source link

Error code after implementing #1

Open Uzaaft opened 3 years ago

Uzaaft commented 3 years ago

Switching to spacegray-trans, I get the following issue image Using Nvim v.0.5.0 Using LunarVim. The theme works, but any idea how to solve the error?

gnmearacaun commented 3 years ago

Hi @Uzaaft Although this repo is only 7 days old it is already depreciated. Chris updated spacegray an hour ago and all you have to do (I see you've using rolling) is add O.transparent_window = true to your lv-config and you're good to go. I'll probably remove this repo. Let me know if you run into problems.

gnmearacaun commented 3 years ago

In fact that setting will make all the themes transparent! One issue I run into with transparent themes is that the comments are too faint. (I have a slideshow of thousands of images in the background) For spacegray I set gray = "#b5b5b5", in lua/spacegray/palette.lua

Uzaaft commented 3 years ago

The thing is that the space grey theme supplied in LunarVIm does not make my nerdtree transparent with O.transparent_window = true. Your's do. But I guess I'll open up an issue there.

gnmearacaun commented 3 years ago

I fixed the issue by just commenting that line out. If you re-clone space-gray-trans it works again. It took a moment, because I had to revert from breaking changes in roling this morning. That is a problem with Chris's new theme; the other themes are transparent for NvimTree and below the status bar. If I can figure out what to change I will put in a PR

gnmearacaun commented 3 years ago

I made the comments brighter. A bit easier to read.

Uzaaft commented 3 years ago

I find the new comments better with the level of opacity that I have in Alacritty! Thank you for fixing the issue!

gnmearacaun commented 3 years ago

For sure. Easier to see on a variety of backgrounds. I opened an issue on the lv repo about spacevim and also have requested lighter comments (gray = #9a9a9a) when when O.transparent_window = true

gnmearacaun commented 3 years ago

Here I have set comments to a1a1a1 so you can always change that value. Let me know if you find a better color. Thanks