gnmyt / myspeed

A speed test analysis software that shows your internet speed for up to 30 days
https://myspeed.dev
MIT License
212 stars 14 forks source link

[Bug] Intergrations - Pushover - User Key Issue #726

Open mnrivera210 opened 1 week ago

mnrivera210 commented 1 week ago

General

The Bug

I'm unable to save my Pushover settings when entering the User Key. It appears that when any letter is capitalized it will not save and remains red. The user key provided contains capital letters along with lowercase.

What device are you using to access the page?

In the browser

Which operating system is your MySpeed instance running on?

Linux

gnmyt commented 5 days ago

Hi, does this only happen on the user key? The user key and the app token share the same regex (/^[a-z0-9]{30}$/), so it should also happen on the app key (if there are uppercase characters).

During my tests, it only gave me a lowercase key with numbers and characters. I also couldn't find any documentation on how the key key is built on their side.

I'll run more tests on trying to get an uppercase user key and create a PR that will fix this! Thanks for reporting this :)

mnrivera210 commented 1 day ago

My app key only consists of lowercase, but seems to behave the same if a letter is upper. I changed all my uppercase letters to lowercase ones on my user key and the integration works. I appreciate your development!