search

gnocchixyz / gnocchi

Timeseries database
Apache License 2.0
299 stars 85 forks source link

Regenerate remote_pb2.py with protoc 3.19.0 #1268

Closed yadneshk closed 2 years ago

yadneshk commented 2 years ago

Execute "protoc --proto_path=. --python_out=. remote.proto" to regenerate remote_pb2.py

Fixes: #1267

Signed-off-by: Yadnesh Kulkarni ykulkarn@redhat.com

yadneshk commented 2 years ago

Used the same command from https://github.com/gnocchixyz/gnocchi/blob/master/gnocchi/rest/prometheus/README to recomplie remote_pb2.py file

eyalb1 commented 2 years ago

I think you need to change the version to be>4.0.0 https://github.com/gnocchixyz/gnocchi/blob/master/setup.cfg#L84

kajinamit commented 2 years ago

I think you need to change the version to be>4.0.0 https://github.com/gnocchixyz/gnocchi/blob/master/setup.cfg#L84

I agree that we should update the version requirement. I could not find any good material explaining the minimum version but I think >= 3.19.0 would be reasonable because the code is regenerated with protoc 3.19.0

yadneshk commented 2 years ago

@tobias-urdin @mrunge please let me know your thoughts on this pull request

tobias-urdin commented 2 years ago

Thanks for looking at this, I would like to know if we need to enforce a minimum version of protobuf package, anybody knows?

yadneshk commented 2 years ago

We could set it to protobuf>=4.21.1

tobias-urdin commented 2 years ago

I guess we could do >= 3.19.0 since that's what the error message says, since the unpin here works with latest protobuf. We need 3.19 as well since we still support Python 3.6