search

gnocchixyz / gnocchi

Timeseries database
Apache License 2.0
299 stars 85 forks source link

Fix gnocchi build with latest setuptools #1305

Closed keuko closed 1 year ago

keuko commented 1 year ago

Setuptools removed deprecated APIs in easy_install: get_script_args, get_script_header and get_writer. The direct usage of easy_install has been deprecated since v58.3.0, and the warnings regarding these APIs predate that version.

This patch fix this issue by replacing direct easy_install call easy_install.get_script_header() with easy_install.ScriptWriter.get_header().

Build error:

AttributeError: module 'setuptools.command.easy_install' has no attribute 'get_script_header'

Fixes gnocchixyz/gnocchi#1304

artificial-intelligence commented 1 year ago

notice though that easy_install itself is deprecated as well.

it is suggested to use pip instead:

https://setuptools.pypa.io/en/stable/deprecated/easy_install.html

tobias-urdin commented 1 year ago

immediate issue will be fixed by https://github.com/gnocchixyz/gnocchi/pull/1314 – still using deprecated behaviour will perhaps use the opened pbr patch for that if details can be sorted out

tobias-urdin commented 1 year ago

Closing as immediate issue is fixed in stable branches and master now completely removed that code https://github.com/gnocchixyz/gnocchi/pull/1327