Closed stephenfin closed 1 year ago
I like this approach, more elegant than trying to integrate pbr or pip. We could perhaps nuke the two lines to setuptools.setup() function as well right?
We could perhaps nuke the two lines to setuptools.setup() function as well right?
Yeah, I've done that in #1325
oooohhh, sweet!
We were wrapping easy_install's
install_scripts
anddevelop
methods to generate a custom WSGI script. This was a replacement of functionality previously provided by PBR. Unfortunately easy_install is deprecated for removal at a future date and we don't yet have a modern equivalent in pip [1]. As such, we need a migration plan for this and it seems like the old schoolscripts
option is probably it. The main downside of this is that the shebang isn't updated accordingly, which means this won't work very well in virtualenvs, but I'm hoping that the use of/usr/bin/env
will allow us to work around this. At least in local testing, it seems like this is the case:EDIT: this also seems to work just fine with wheels:
[1] https://discuss.python.org/t/adding-support-for-wsgi-scripts-entrypoint/30905
Signed-off-by: Stephen Finucane stephenfin@redhat.com