Add minimum requirement for sqlalchemy to 1.4.24

gnocchixyz / gnocchi

Timeseries database

Apache License 2.0

302 stars 85 forks source link

Add minimum requirement for sqlalchemy to 1.4.24 #1350

Closed LazyMan145 closed 8 months ago

LazyMan145 commented 1 year ago

Some of the recent sqlalchemy 2 changes used features that were added in 1.4.24 sqlalchemy (session.scalar) [1]. This change fixes the issue with gnocchi-upgrade built with wrong constraints.

https://docs.sqlalchemy.org/en/20/changelog/changelog_14.html#change-e619b9bd2796d7e0b948631fac5b01e9

LazyMan145 commented 1 year ago

Fixes #1349

tobias-urdin commented 1 year ago

This will be green when it's rebased.

rafaelweingartner commented 9 months ago

Do w need this patch, and the others that are in the series? I mean, the constraint is defining a lower bound. Therefore, the installer will normally try to take the latest one possible. Only if it is not possible, that the installer would take a smaller version. Or, if it is already installed.

Are we sure this is a change that we need?

tobias-urdin commented 9 months ago

@mergifyio rebasem

tobias-urdin commented 9 months ago

@mergifyio rebase