search

gnocchixyz / gnocchi

Timeseries database
Apache License 2.0
298 stars 84 forks source link

Update code for breaking change in werkzeug #1354

Closed dbalagansky closed 8 months ago

dbalagansky commented 9 months ago

parse_authorization_header was removed here: https://github.com/pallets/werkzeug/commit/bafffa9fb597156567c1ca80042bfbc842a42284.

tobias-urdin commented 8 months ago

Hello @dbalagansky thanks a lot for finding this breaking change that was blocking the upgrade jobs!

I've merged a pinning of werkzeug<3.0.0 on all stable branches to get CI on all branches working again and also merged that on master branch with [1].

Please rebase this on master and unpin werkzeug completely (we don't pin unless it's on stable branches usually). I also think we need to workaround supporting werkzeug<3.0.0 on master as well so you'd need to add a try-except for this case.

Have a nice weekend!

[1] https://github.com/gnocchixyz/gnocchi/pull/1356

tobias-urdin commented 8 months ago

Thanks!

noonedeadpunk commented 4 months ago

Folks, can we backport that to stable/4.6 ?

tobias-urdin commented 4 months ago

@mergifyio backport stable/4.6

tobias-urdin commented 4 months ago

@noonedeadpunk ^ I can look into backporting and release a new minor version with that

mergify[bot] commented 4 months ago

backport stable/4.6

✅ Backports have been created

* [#1379 Update code for breaking change in werkzeug (backport #1354)](https://github.com/gnocchixyz/gnocchi/pull/1379) has been created for branch `stable/4.6`
tobias-urdin commented 4 months ago

@noonedeadpunk 4.6.2 is released