search

gnocchixyz / gnocchi

Timeseries database
Apache License 2.0
302 stars 85 forks source link

Fix time format for datetime objects #1361

Closed rafaelweingartner closed 11 months ago

rafaelweingartner commented 12 months ago

The date manipulation in Gnocchi to generate the response is quite odd, which is causing some weird outputs if the nanoseconds part of the string has some value different from .000000000; this patch is changing that to a better approach.

This was extract from https://github.com/gnocchixyz/gnocchi/pull/1307#discussion_r1330867035

rafaelweingartner commented 12 months ago

Errors do not seem to be related to the change. Do you guys need any help to fix/find the root cause of the errors?

pedro-martins commented 12 months ago

@rafaelweingartner, this PR https://github.com/gnocchixyz/gnocchi/pull/1362 fixes the errors, you can rebase your PR from it, it should fix the tests errors

rafaelweingartner commented 12 months ago

@rafaelweingartner, this PR #1362 fixes the errors, you can rebase your PR from it, it should fix the tests errors

Thanks! I already reviewed, and approved!