search

gnocchixyz / gnocchi

Timeseries database
Apache License 2.0
298 stars 84 forks source link

Remove unused dependency #1383

Closed kajinamit closed 1 month ago

kajinamit commented 3 months ago

The trollius library is required only in Python <= 3.4, but currently Python 3.8 is the minimum supported version.

rafaelweingartner commented 1 month ago

Isn't this used here?

import trollius as asyncio

https://github.com/gnocchixyz/gnocchi/blob/master/gnocchi/statsd.py#L21

kajinamit commented 1 month ago

Isn't this used here?

import trollius as asyncio

https://github.com/gnocchixyz/gnocchi/blob/master/gnocchi/statsd.py#L21

Oops. Good catch. I removed the ImportError fallback because the asyncio module is available in all of the python versions currently supported (python >= 3.8) and the fallback is not actually used.