search

gnocchixyz / gnocchi

Timeseries database
Apache License 2.0
302 stars 85 forks source link

Change code to support numpy to 2.0 #1390

Closed rafaelweingartner closed 5 months ago

pedro-martins commented 5 months ago

I see the changes you did to adapt the code to the new numpy version, but where are you changing it to 2.0?

rafaelweingartner commented 5 months ago

I see the changes you did to adapt the code to the new numpy version, but where are you changing it to 2.0?

I am not. As @chungg recommended there might be people using numpy < 2.0, which also supports the new syntax. The thing is that in numpy > 2.0 the old NaN is not supported anymore.

pedro-martins commented 5 months ago

I didnt see this review, github hid it from me. Now I saw the chung suggestion.

Maybe if you could change the MR title, it could help new reviewers as now you are not updating numpy anymore but making the code compatible with new versions.

rafaelweingartner commented 5 months ago

I didnt see this review, github hid it from me. Now I saw the chung suggestion.

Maybe if you could change the MR title, it could help new reviewers as now you are not updating numpy anymore but making the code compatible with new versions.

Done. I changed the title. What do you think?

pedro-martins commented 5 months ago

Cool, thanks :)

The code looks good to me