search

gnocchixyz / gnocchi

Timeseries database
Apache License 2.0
302 stars 85 forks source link

Function call issue for parsing sentinel_fallback #1405

Closed itsfarbod closed 2 months ago

itsfarbod commented 3 months ago

Hi, The _parse_sentinel was a class function and when it get called by

sentinel_hosts = [
            _parse_sentinel(fallback)
            for fallback in kwargs.pop('sentinel_fallback', [])
        ]

It made errors because it doesn't pass cls to it and it can't receive the sentinel. So I made it static and tested it and its OK now.

tobias-urdin commented 2 months ago

@mergifyio backport stable/4.6

mergify[bot] commented 2 months ago

backport stable/4.6

✅ Backports have been created

* [#1407 Function call issue for parsing sentinel_fallback (backport #1405)](https://github.com/gnocchixyz/gnocchi/pull/1407) has been created for branch `stable/4.6`