gnocode / noladex.org

People of New Orleans
http://www.noladex.org
21 stars 10 forks source link

refactored users controller to use named scope in users model #1

Closed joeellis closed 13 years ago

joeellis commented 13 years ago

Changed index method to use a named scope that's a bit easier to read, as well as use ActiveRecord :include option to create joins to avoid n+1 queries

edward commented 13 years ago

Nice! Looking forward to seeing an infinite scrolling technique like on http://apps.shopify.com - I'm using jquery there with a few other tricks, but it should be pretty easy to implement and speed up the loading time of the site.

On Monday, July 18, 2011 at 10:05 PM, joeellis wrote:

Changed index method to use a named scope that's a bit easier to read, as well as use ActiveRecord :include option to create joins to avoid n+1 queries

Reply to this email directly or view it on GitHub: https://github.com/gnocode/peopleofneworleans/pull/1

joeellis commented 13 years ago

Thanks. Yes, that's actually my very next branch I'm working on, I was planning on implementing infinite scroll with Kaminari paging and sausage.js unless you've got a better pagination / js scrolling plugin combo that you'd recommend.

Joe Ellis squarefour | www.squarefour.net 504.267.9321 joe@squarefour.net

On Monday, July 18, 2011 at 9:59 PM, edward wrote:

Nice! Looking forward to seeing an infinite scrolling technique like on http://apps.shopify.com - I'm using jquery there with a few other tricks, but it should be pretty easy to implement and speed up the loading time of the site.

On Monday, July 18, 2011 at 10:05 PM, joeellis wrote:

Changed index method to use a named scope that's a bit easier to read, as well as use ActiveRecord :include option to create joins to avoid n+1 queries

Reply to this email directly or view it on GitHub: https://github.com/gnocode/peopleofneworleans/pull/1

Reply to this email directly or view it on GitHub: https://github.com/gnocode/peopleofneworleans/pull/1#issuecomment-1604231